Skip to content
This repository was archived by the owner on Feb 16, 2026. It is now read-only.

h2: Add a rate limit facility for h/2 RST handling (6.0)#4008

Merged
dridi merged 10 commits into
varnishcache:6.0from
dridi:pulls_3997_3999_6.0
Oct 18, 2023
Merged

h2: Add a rate limit facility for h/2 RST handling (6.0)#4008
dridi merged 10 commits into
varnishcache:6.0from
dridi:pulls_3997_3999_6.0

Conversation

@dridi

@dridi dridi commented Oct 18, 2023

Copy link
Copy Markdown
Member

This is a port of #3997 and #3999 mostly performed by @daghf.

asadsa92 and others added 10 commits October 18, 2023 17:33
This should make the code easier to read and stop us from being inconsistent.

Signed-off-by: Asad Sajjad Ahmed <asadsa@varnish-software.com>
This adds parameters h2_rapid_reset_limit and h2_rapid_reset_period,
which govern the rate of which we permit clients to reset streams.

If the limit is exceeded the connection is closed.

Related to: varnishcache#1851

Conflicts:
	include/tbl/params.h
Conflicts:
	bin/varnishd/VSC_main.vsc
	include/tbl/sess_close.h
Only RST frames received earlier than this duration will be considered
rapid.

Includes backports of the following upstream doc-touchups:
- 151f4d5
- 46d4f82

Conflicts:
	include/tbl/params.h
backport of f820f80

Conflicts:
	include/tbl/params.h
Backport of 2cfb561 and 1a406e3

Conflicts:
	bin/varnishtest/vmods.h
	configure.ac
	lib/Makefile.am
we can not make the parameter const because API.
@dridi

dridi commented Oct 18, 2023

Copy link
Copy Markdown
Member Author

Once again, failing tests are timing out and registered in #4002, ready to merge.

@dridi
dridi merged commit b9ef357 into varnishcache:6.0 Oct 18, 2023
@dridi
dridi deleted the pulls_3997_3999_6.0 branch October 18, 2023 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants